Offering Some Help - Release 0.3 PR1

Introduction

For this pull request, I searched for a project using the help wanted tag on github. Eventually I found a project that seemed like I would be able to help with. It was a CLI that would take in a file with pseudo code and convert it to python code and run it. This seemed like an interesting concept as well as something that I would be able to help with. 

Issue

The issue I decided to help with was one were the correct CLI did not have any way to convert two expressions being compared with a logic gate, for example X > Y AND X< Z. They CLI already had a function that compares to variables with an operator so building on that functionality was the task. 



Making this functionality work involved creating a new function that would receive two arrays and string that represented the logic gate. Each array would contain two values and an operator which when then be passed to the compare function that already existed. Once the outcome of calling the compare function was returned then further evaluation would take place with the logic gate that was passed to this function. The most interesting part of this PR was trying to keep the coding style consistent with the owner of the repo as they had made a few stylistic choices that I would not normally make. 

Comments

Post a Comment

Popular posts from this blog

Adding Features and Pull Request

Week 3 OSD600 - Pull Requests   This week, our class took a look at each other's release from the previous week and were tasked with finding an issue or suggesting an improvement/adding a feature and then implementing that fix or improvement in the from of a  pull request. This week I decided to once again took a look at Matt's CheckMyLinks python tool.  Finding Issues or Suggesting an Improvement While reviewing Matt's code, I couldn't really find any issues that I could fix, so I instead I decided to look for ways I could think of to improve his tool. I had a couple ideas but the one I decided to go with was to add an option that would allow the user to save the results of the link check to a text file. I thought this would be useful so the user can have a reference of the results after leaving the command line. I left an issue request on Matt's repo and began to implement the improvement.  Implementing Improvement   The first thing I did when starting to code t
Read more

Planning for Release 0.4

 For this final release I was able to find a project that has created a reddit bot that scans titles in reddit subreddits and if it matches the criteria laid out in the code it offers the poster some useful resources and/or some great projects to begin practicing coding. I thought this was a worthwhile project as this is something that would definitely be helpful to me and it seems like a great addition to the programming  community.  The specific issue that I wanted to work on was one were the creator of the bot had all the code for the bot basically in one python file and the file was growing to over 500 lines and he wanted to move to a more modular approach that would include separating out the logic into different files. I thought this would be a good issue to tackle because it would require me to get a full understanding of the code as well as add optimizations throughout while a separated out the code.  The approach I plan to take is first to review the code so I can get a more
Read more

Release 0.4 Progress - Organizing the code

 After taking some time to understand the code that runs the bot, I was able to separate the code out into a few different categories that would be placed into their own files, code that creates the classes that manage the checking of reddit posts and comments, code that manages the bot streaming and posting to reddit, code that initialized the initial state of the bot and code that provides general utility to the bot.  Once I was able to separate out all that logic, the next issue I need to tackle now is how to make the code work while flowing through these different files. Currently since the app operates in one file, the bot creator has been making use of a lot of global variables instead of constantly passing variables through several functions. I dont think this solution is ideal so I currently I am working on a more efficient solution that doesnt involve passing several variables across functions and files. I think perhaps creating a dictionary that contains critical data that ca
Read more